check Ruby strings for embedded null bytes #69

Merged
cremno merged 1 commits from check-ruby-string-for-embedded-null-bytes into master 2014-09-12 21:30:07 +00:00
cremno commented 2014-09-12 13:25:39 +00:00 (Migrated from github.com)

Kinda forgot about it. Let's try this. I doubt this will break a game and it's the correct way anyway.

Kinda forgot about it. Let's try this. I doubt this will break a game and it's the correct way anyway.
Ancurio commented 2014-09-12 21:29:53 +00:00 (Migrated from github.com)

Thanks cremno. I'll pull this, but let me just explain why I don't fully agree with the first change. Usually, a change to code behavior should either

    1. Move the behavior closer to RGSS
    1. Improve performance or
    1. Reduce code size / improve maintainability

(in descending priority). This change violates the first and doesn't meet the 2nd and 3rd.

Thanks cremno. I'll pull this, but let me just explain why I don't fully agree with the first change. Usually, a change to code behavior should either - 1) Move the behavior closer to RGSS - 2) Improve performance or - 3) Reduce code size / improve maintainability (in descending priority). This change violates the first and doesn't meet the 2nd and 3rd.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MapleShrine/mkxp#69
No description provided.