MapleShrine/mkxp
1
0
Fork 0
Code Issues 32 Pull requests 11 Projects Releases Wiki Activity

Convert nil int/float arguments to 0 #227

Open
Cloudef wants to merge 1 commit from Cloudef/ruby-game-compatibility into master
pull from: Cloudef/ruby-game-compatibility
merge into: MapleShrine:master
Conversation 8 Commits 1 Files changed 1 +10 -2
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
binding-mri/binding-util.h
View file

@ -227,8 +227,12 @@ rb_float_arg(VALUE arg, double *out, int argPos = 0)
*out = FIX2INT(arg);
break;
case RUBY_T_NIL :
*out = 0;
break;
carstene1ns commented 2020-03-25 12:02:07 +00:00 (Migrated from github.com)
Review
Copy link

Wrong indentation (use tabs).

Wrong indentation (use tabs).
Cloudef commented 2020-03-25 13:13:22 +00:00 (Migrated from github.com)
Review
Copy link

Guess I have to configure my editor to not convert tabs ...

Guess I have to configure my editor to not convert tabs ...
Cloudef commented 2020-03-25 13:18:36 +00:00 (Migrated from github.com)
Review
Copy link

Also would you happen to know what are the exact tab width etc settings for this project.

Also would you happen to know what are the exact tab width etc settings for this project.
default:
rb_raise(rb_eTypeError, "Argument %d: Expected float", argPos);
rb_raise(rb_eTypeError, "Argument %d: Expected float (got 0x%x)", argPos, rb_type(arg));
}
}
@ -246,8 +250,12 @@ rb_int_arg(VALUE arg, int *out, int argPos = 0)
*out = FIX2INT(arg);
break;
case RUBY_T_NIL :
*out = 0;
break;
default:
rb_raise(rb_eTypeError, "Argument %d: Expected fixnum", argPos);
rb_raise(rb_eTypeError, "Argument %d: Expected fixnum (got 0x%x)", argPos, rb_type(arg));
}
}