Allow using multiple ttf files with separate styles of same family #220

Open
pulsejet wants to merge 1 commits from pulsejet/fontstyle into master
pulsejet commented 2019-05-12 10:38:11 +00:00 (Migrated from github.com)

This is done by keeping a BoostHash of all the styles we have and their corresponding paths, and passing the style when we want to get the font.

This is done by keeping a BoostHash of all the styles we have and their corresponding paths, and passing the style when we want to get the font.
carstene1ns commented 2019-05-12 16:10:53 +00:00 (Migrated from github.com)

I really hoped we could be boost-free nowadays... 😞

I really hoped we could be boost-free nowadays... :disappointed:
pulsejet commented 2019-05-12 19:55:01 +00:00 (Migrated from github.com)

@carstene1ns BoostHash is not boost xD. I'm using it just for consistency. This actually would make it easier if we wanted to transition that class to C++11 (you can literally replace all instances of boost::unordered_map in boost-hash.h with std::map and it just works; do the same thing for unordered_set and you no longer need to compile boost).

@carstene1ns `BoostHash` is _not_ boost xD. I'm using it just for consistency. This actually would make it easier if we wanted to transition that class to C++11 (you can literally replace all instances of `boost::unordered_map` in `boost-hash.h` with `std::map` and it just works; do the same thing for `unordered_set` and you no longer need to compile boost).
Ancurio commented 2019-05-13 08:57:42 +00:00 (Migrated from github.com)

Yeah, I wrote BoostHash just to mimic the API of QHash, its predecessor.

Yeah, I wrote BoostHash just to mimic the API of QHash, its predecessor.
Ghabry commented 2019-07-03 17:51:56 +00:00 (Migrated from github.com)

@pulsejet well there is still boost::program_options which is not trivial to replace or do you have an alternative for this? :o

@pulsejet well there is still boost::program_options which is not trivial to replace or do you have an alternative for this? :o
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b pulsejet/fontstyle master
git pull origin pulsejet/fontstyle

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff pulsejet/fontstyle
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MapleShrine/mkxp#220
No description provided.