MapleShrine/mkxp
1
0
Fork 0
Code Issues 32 Pull requests 11 Projects Releases Wiki Activity

MRI: some minor optimizations #16

Merged
cremno merged 1 commit from mri-minor-optimizations into master 2014-01-25 08:23:26 +00:00
Conversation 1 Commits 1 Files changed 6 +24 -22
cremno commented 2014-01-24 21:48:46 +00:00 (Migrated from github.com)
Copy link

Just some random tiny issues I found while reading the code. I probably should've put an explanation for each one of them in the commit message but (I forgot it and) I think the changes are straight forward (if you have some basic CRuby knowledge).

Just some random tiny issues I found while reading the code. I probably should've put an explanation for each one of them in the commit message but (I forgot it and) I think the changes are straight forward (if you have some basic CRuby knowledge).
Ancurio commented 2014-01-25 08:22:31 +00:00 (Migrated from github.com)
Copy link

Yeah, looks good. I didn't know rb_type was an inlined function (just assumed a macro'ed struct accessor like in mruby), good to know.

Thank you.

Yeah, looks good. I didn't know `rb_type` was an inlined function (just assumed a macro'ed struct accessor like in mruby), good to know. Thank you.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
RGSS accuracy

   
bug

   
compilation

   
discussion

   
documentation

   
duplicate

   
enhancement

   
invalid

   
performance issue

   
port request

   
question

   
ruby incompatibility

   
wontfix
No labels
RGSS accuracy
bug
compilation
discussion
documentation
duplicate
enhancement
invalid
performance issue
port request
question
ruby incompatibility
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: MapleShrine/mkxp#16
No description provided.
Delete branch "mri-minor-optimizations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?