MRI: Stub out Graphics.play_movie #138
No reviewers
Labels
No Label
RGSS accuracy
bug
compilation
discussion
documentation
duplicate
enhancement
invalid
performance issue
port request
question
ruby incompatibility
wontfix
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: MapleShrine/mkxp#138
Loading…
Reference in New Issue
No description provided.
Delete Branch "graphics-playmovie-stub"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Some people are using it to detect the RGSS version. (Line 52 in this script.)
Obviously this doesn't actually play any movies, but it's better than crashing :)
Let me know if I'm making too many PRs or whatever :)
What? No way, contributions are always very welcome! Although the codebase is badly documented so it might unfortunately deter some :)
Also, having separate PRs for fixes towards unrelated parts of the code is definitely the right way to do it.
Stubbed out in
graphics.cpp
instead, as requested in8bd1d9b49d
. (Sorry, force push erased it from the PR.) Also, fixed a problem where I was accidentally exposing it in RGSS2 (which sort of defeats the purpose of the script this was trying to fix). Thanks for the feedback!Ah, right, the force push causes the comments to become disattached from this PR. But no worries, force-pushing is a lot better than what I think github wants us to do (endlessly append "fix" commits onto PRs), because the final commit history stays clean.
Other than the minor tab nitpick, it looks great!
Tab thing fixed. Commented because IIRC github doesn't notify on forced push to a PR.
Thanks for your work!