fix some integer conversions in the Table class #60

Merged

cremno merged 2 commits from mri-table-fix-conversions into master

2014-08-31 09:20:09 +00:00

cremno commented

2014-08-31 03:01:08 +00:00

(Migrated from github.com)

Sizes (x, y, z) are clamped to a non-negative int value.
Use NUM2INT instead of FIX2INT as the argument might not be a Fixnum.

Sizes (x, y, z) are clamped to a non-negative int value. Use NUM2INT instead of FIX2INT as the argument might not be a Fixnum.

Ancurio commented

2014-08-31 09:04:20 +00:00

(Migrated from github.com)

Small nitpick: Can you use std::max instead of the ternary op?

Small nitpick: Can you use `std::max` instead of the ternary op?

cremno commented

2014-08-31 09:16:29 +00:00

(Migrated from github.com)

I've changed it.

Ancurio commented

2014-08-31 09:19:57 +00:00

(Migrated from github.com)

Thank you!~

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: MapleShrine/mkxp#60

No description provided.

Rows
Columns