MapleShrine
/
mkxp
1
0
Fork 0
Code Issues 32 Pull Requests 11 Projects Releases Wiki Activity

Button config menu should save config to disk whenever changes are accepted. #85

Merged
Daverball merged 2 commits from save-button-config into master 2014-12-31 13:13:53 +00:00
Conversation 1 Commits 2 Files Changed 2 +3 -5
Daverball commented 2014-12-27 13:42:55 +00:00 (Migrated from github.com)
Copy Link

As discussed in https://github.com/Ancurio/mkxp/pull/83 I think button config changes should be saved to disk whenever someone is finished setting them up and not only when mkxp exits, since mkxp might crash and thus not save the config.

As discussed in https://github.com/Ancurio/mkxp/pull/83 I think button config changes should be saved to disk whenever someone is finished setting them up and not only when mkxp exits, since mkxp might crash and thus not save the config.
Ancurio commented 2014-12-28 04:51:48 +00:00 (Migrated from github.com)
Copy Link

Oh right I forgot, this means you can now also remove the storing code from main() since it doesn't do anything useful anymore.

Oh right I forgot, this means you can now also remove the storing code from main() since it doesn't do anything useful anymore.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
RGSS accuracy

   
bug

   
compilation

   
discussion

   
documentation

   
duplicate

   
enhancement

   
invalid

   
performance issue

   
port request

   
question

   
ruby incompatibility

   
wontfix
No Label
RGSS accuracy
bug
compilation
discussion
documentation
duplicate
enhancement
invalid
performance issue
port request
question
ruby incompatibility
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MapleShrine/mkxp#85
No description provided.
Delete Branch "save-button-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?