MRI binding: changes to Marshal::load mkxp's custom proc #2

Merged
cremno merged 2 commits from mri-marshal-utf8proc into master 2013-10-23 03:29:51 +00:00
cremno commented 2013-10-22 11:49:08 +00:00 (Migrated from github.com)
  • force string encoding to UTF-8 only when it's ASCII-8BIT (force only valid UTF-8 strings in future?)
  • support original Marshal::load proc (2nd arg)
- force string encoding to UTF-8 only when it's ASCII-8BIT (force only valid UTF-8 strings in future?) - support original Marshal::load proc (2nd arg)
Ancurio commented 2013-10-22 13:12:37 +00:00 (Migrated from github.com)

Looking great! Just two small nitpicks: can you use camelCase for function names and leave one empty line before the 'return' statement? Otherwise this is good to go.

Looking great! Just two small nitpicks: can you use camelCase for function names and leave one empty line before the 'return' statement? Otherwise this is good to go.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MapleShrine/mkxp#2
No description provided.