MapleShrine/mkxp
1
0
Fork 0
Code Issues 32 Pull requests 11 Projects Releases Wiki Activity

Bitmap: Don't throw away cached surface in setPixel()

Browse source 
Instead, update the surface with the same change. For many
consecutive getPixel() -> setPixel() calls on the same bitmap,
this avoids calling glReadPixels at every iteration.
This commit is contained in:
Jonas Kulla 2016-07-27 11:59:08 +02:00
parent fdaf6c3611
commit e98c2e0535
1 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/bitmap.cpp
View file

@ -221,9 +221,9 @@ struct BitmapPrivate
surf = surfConv; surf = surfConv;
} }
void onModified() void onModified(bool freeSurface = true)
{ {
if (surface) if (surface && freeSurface)
{ {
SDL_FreeSurface(surface); SDL_FreeSurface(surface);
surface = 0; surface = 0;
@ -825,7 +825,16 @@ void Bitmap::setPixel(int x, int y, const Color &color)
p->addTaintedArea(IntRect(x, y, 1, 1)); p->addTaintedArea(IntRect(x, y, 1, 1));
p->onModified(); /* Setting just a single pixel is no reason to throw away the
* whole cached surface; we can just apply the same change */
if (p->surface)
{
uint32_t &surfPixel = getPixelAt(p->surface, p->format, x, y);
surfPixel = SDL_MapRGBA(p->format, pixel[0], pixel[1], pixel[2], pixel[3]);
}
p->onModified(false);
} }
void Bitmap::hueChange(int hue) void Bitmap::hueChange(int hue)