MapleShrine/mkxp
1
0
Fork 0
Code Issues 32 Pull requests 11 Projects Releases Wiki Activity

Pass value object attributes by reference (instead of pointer)

Browse source 
This underlines that no reference inside the setter is taken,
and that these attributes are non-nullable.

Also removes a couple of superfluous attribute macros.
This commit is contained in:
Jonas Kulla 2014-10-25 23:33:41 +02:00
parent 5549ff78f0
commit c9d5059238
29 changed files with 92 additions and 110 deletions
Download patch file Download diff file Expand all files Collapse all files

2
binding-mri/binding-util.h
View file

@ -340,7 +340,7 @@ rb_check_argc(int actual, int expected)
VALUE propObj = *argv; \
PropKlass *prop; \
prop = getPrivateDataCheck<PropKlass>(propObj, PropKlass##Type); \
GUARD_EXC( k->set##PropName(prop); ) \
GUARD_EXC( k->set##PropName(*prop); ) \
return propObj; \
}

16
binding-mri/font-binding.cpp
View file

@ -60,10 +60,10 @@ RB_METHOD(fontInitialize)
/* Wrap property objects */
f->initDynAttribs();
wrapProperty(self, f->getColor(), "color", ColorType);
wrapProperty(self, &f->getColor(), "color", ColorType);
if (rgssVer >= 3)
wrapProperty(self, f->getOutColor(), "out_color", ColorType);
wrapProperty(self, &f->getOutColor(), "out_color", ColorType);
if (NIL_P(name))
name = rb_iv_get(rb_obj_class(self), "default_name");
@ -90,10 +90,10 @@ RB_METHOD(fontInitializeCopy)
/* Wrap property objects */
f->initDynAttribs();
wrapProperty(self, f->getColor(), "color", ColorType);
wrapProperty(self, &f->getColor(), "color", ColorType);
if (rgssVer >= 3)
wrapProperty(self, f->getOutColor(), "out_color", ColorType);
wrapProperty(self, &f->getOutColor(), "out_color", ColorType);
return self;
}
@ -209,7 +209,7 @@ RB_METHOD(FontSetDefaultOutColor)
Color *c = getPrivateDataCheck<Color>(colorObj, ColorType);
Font::setDefaultOutColor(c);
Font::setDefaultOutColor(*c);
return colorObj;
}
@ -248,7 +248,7 @@ RB_METHOD(FontSetDefaultColor)
Color *c = getPrivateDataCheck<Color>(colorObj, ColorType);
Font::setDefaultColor(c);
Font::setDefaultColor(*c);
return colorObj;
}
@ -266,11 +266,11 @@ fontBindingInit()
rb_define_alloc_func(klass, classAllocate<&FontType>);
Font::initDefaultDynAttribs();
wrapProperty(klass, Font::getDefaultColor(), "default_color", ColorType);
wrapProperty(klass, &Font::getDefaultColor(), "default_color", ColorType);
rb_iv_set(klass, "default_name", rb_str_new_cstr(Font::getDefaultName()));
if (rgssVer >= 3)
wrapProperty(klass, Font::getDefaultOutColor(), "default_out_color", ColorType);
wrapProperty(klass, &Font::getDefaultOutColor(), "default_out_color", ColorType);
INIT_KLASS_PROP_BIND(Font, DefaultName, "default_name");
INIT_KLASS_PROP_BIND(Font, DefaultSize, "default_size");

4
binding-mri/plane-binding.cpp
View file

@ -35,8 +35,8 @@ RB_METHOD(planeInitialize)
p->initDynAttribs();
wrapProperty(self, p->getColor(), "color", ColorType);
wrapProperty(self, p->getTone(), "tone", ToneType);
wrapProperty(self, &p->getColor(), "color", ColorType);
wrapProperty(self, &p->getTone(), "tone", ToneType);
return self;
}

6
binding-mri/sprite-binding.cpp
View file

@ -39,9 +39,9 @@ RB_METHOD(spriteInitialize)
/* Wrap property objects */
s->initDynAttribs();
wrapProperty(self, s->getSrcRect(), "src_rect", RectType);
wrapProperty(self, s->getColor(), "color", ColorType);
wrapProperty(self, s->getTone(), "tone", ToneType);
wrapProperty(self, &s->getSrcRect(), "src_rect", RectType);
wrapProperty(self, &s->getColor(), "color", ColorType);
wrapProperty(self, &s->getTone(), "tone", ToneType);
return self;
}

6
binding-mri/viewport-binding.cpp
View file

@ -64,9 +64,9 @@ RB_METHOD(viewportInitialize)
/* Wrap property objects */
v->initDynAttribs();
wrapProperty(self, v->getRect(), "rect", RectType);
wrapProperty(self, v->getColor(), "color", ColorType);
wrapProperty(self, v->getTone(), "tone", ToneType);
wrapProperty(self, &v->getRect(), "rect", RectType);
wrapProperty(self, &v->getColor(), "color", ColorType);
wrapProperty(self, &v->getTone(), "tone", ToneType);
/* 'elements' holds all SceneElements that become children
* of this viewport, so we can dispose them when the viewport

2
binding-mri/window-binding.cpp
View file

@ -34,7 +34,7 @@ RB_METHOD(windowInitialize)
w->initDynAttribs();
wrapProperty(self, w->getCursorRect(), "cursor_rect", RectType);
wrapProperty(self, &w->getCursorRect(), "cursor_rect", RectType);
return self;
}

4
binding-mri/windowvx-binding.cpp
View file

@ -53,10 +53,10 @@ RB_METHOD(windowVXInitialize)
w->initDynAttribs();
wrapProperty(self, w->getCursorRect(), "cursor_rect", RectType);
wrapProperty(self, &w->getCursorRect(), "cursor_rect", RectType);
if (rgssVer >= 3)
wrapProperty(self, w->getTone(), "tone", ToneType);
wrapProperty(self, &w->getTone(), "tone", ToneType);
Bitmap *contents = new Bitmap(1, 1);
VALUE contentsObj = wrapObject(contents, BitmapType);